replay: gracefully exit if tower load fails #35269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #35269 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 834 833 -1
Lines 224827 224824 -3
=========================================
- Hits 183538 183512 -26
- Misses 41289 41312 +23 |
steviez
reviewed
Feb 21, 2024
AshwinSekar
force-pushed
the
load-tower-panic
branch
from
4621bfa to
f89bb48
Compare
AshwinSekar
force-pushed
the
load-tower-panic
branch
from
f89bb48 to
c755a33
Compare
AshwinSekar
changed the title
steviez
approved these changes
Feb 22, 2024
| err | ||
| ); | ||
| // drop(_exit) will set the exit flag, eventually tearing down the entire process | ||
| return; |
There was a problem hiding this comment.
I guess break and return are effectively equivalent here, since the loop { ... } is the end of the closure
There was a problem hiding this comment.
yeah should be the same
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #35173 (comment)
Summary of Changes
Return a
Resultand set theexitflag ifload_towerfails.